Skip to content

tests.plasma5: Fixes OCR in sddm by providing a custom theme#42327

Merged
matthewbauer merged 1 commit intoNixOS:masterfrom
bkchr:fix_plasma5_test
Jun 21, 2018
Merged

tests.plasma5: Fixes OCR in sddm by providing a custom theme#42327
matthewbauer merged 1 commit intoNixOS:masterfrom
bkchr:fix_plasma5_test

Conversation

@bkchr
Copy link
Contributor

@bkchr bkchr commented Jun 21, 2018 •
edited
Loading

The custom theme just sets the old background colour that OCR works
again.

Motivation for this change

Fixes: #42315

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bkchr
tests.plasma5: Fixes OCR in sddm by providing a custom theme
51bafa6 
The custom theme just sets the old background colour that OCR works
again.
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 21, 2018
@worldofpeace
Copy link
Contributor

worldofpeace commented Jun 21, 2018

Tested it, makes the test do the thing again in the most logical way. 👍

@worldofpeace worldofpeace mentioned this pull request Jun 21, 2018
Closed
@matthewbauer
Copy link
Member

matthewbauer commented Jun 21, 2018

@GrahamcOfBorg test plasma5

@GrahamcOfBorg
Copy link

GrahamcOfBorg commented Jun 21, 2018

Success on x86_64-linux (full log)

Attempted: tests.plasma5

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 119.12s
cleaning up
killing machine (pid 593)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/vmynkx6wbnbg0jss9sx3f6fpmwyq5msk-vm-test-run-plasma5

@matthewbauer matthewbauer merged commit fe948fd into NixOS:master Jun 21, 2018
@GrahamcOfBorg
Copy link

GrahamcOfBorg commented Jun 21, 2018

Success on aarch64-linux (full log)

Attempted: tests.plasma5

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 401.64s
cleaning up
killing machine (pid 627)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/awifdndpdxfaylw5kvaya1z282y61p86-vm-test-run-plasma5

@bkchr bkchr deleted the fix_plasma5_test branch June 22, 2018 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bkchr @worldofpeace @matthewbauer @GrahamcOfBorg